Skip to content

Conversation

@ujfalusi
Copy link
Contributor

4 channel DMIC variant of sof-lnl-cs42l43-l0-cs35l56-l23 family of topologies (DMIC is connected to PCH)

4 channel DMIC variant of sof-lnl-cs42l43-l0-cs35l56-l23 family of
topologies (DMIC is connected to PCH)

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and based on comments in #9930 also tested to work on a S16 device.

"cavs-sdw\;sof-lnl-cs42l43-l0-cs35l56-l23-4ch\;PLATFORM=lnl,NUM_SDW_AMP_LINKS=2,\
SDW_AMP_FEEDBACK=false,SDW_SPK_STREAM=Playback-SmartAmp,\
SDW_JACK_OUT_STREAM=Playback-SimpleJack,SDW_JACK_IN_STREAM=Capture-SimpleJack,NUM_DMICS=4,\
PDM1_MIC_A_ENABLE=1,PDM1_MIC_B_ENABLE=1,\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just looking and comparing to the 2 channel version, should I have enabled the PDM on the MICs?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2 channel DMIC uses PDM0_DMIC and PDM0_MIC_A_ENABLE and PDM0_MIC_B_ENABLE are enabled by default. @singalsu Please correct me if I am wrong.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aaah great thanks!

@kv2019i kv2019i merged commit cfb5941 into thesofproject:main Mar 31, 2025
44 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants